-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Updated GZipCompressionEngine to use GzipCompressorInputStream #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asif Sohail Mohammed <[email protected]>
chenqi0805
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
dlvenable
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
…1570) Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit bde1b52)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
…1570) Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit bde1b52)
asifsmohammed
added a commit
that referenced
this pull request
Jul 8, 2022
…1570) (#1571) Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit bde1b52) Co-authored-by: Asif Sohail Mohammed <[email protected]>
asifsmohammed
added a commit
that referenced
this pull request
Jul 8, 2022
…1570) (#1572) Signed-off-by: Asif Sohail Mohammed <[email protected]> (cherry picked from commit bde1b52) Co-authored-by: Asif Sohail Mohammed <[email protected]>
engechas
pushed a commit
to engechas/data-prepper
that referenced
this pull request
Sep 12, 2022
…pensearch-project#1570) Signed-off-by: Asif Sohail Mohammed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asif Sohail Mohammed [email protected]
Description
This fixes the bug where all the log files are not coming through when logs are new line delimited with GZip compression.
Using apache-commons compress library to fix this by replacing
GZIPInputStream
withGzipCompressorInputStream
.➡️ There will be a separate PR for Integration Testing.
Issues Resolved
Resolves #1568
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.