Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP Health Check for OTelTraceSource and OTelMetricsSource. #1547

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

dinujoh
Copy link
Member

@dinujoh dinujoh commented Jun 28, 2022

Signed-off-by: Dinu John [email protected]

Description

Enable HTTP Health Check for OTelTraceSource and OTelMetricsSource

Issues Resolved

1546

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dinujoh dinujoh requested a review from a team as a code owner June 28, 2022 20:34
dapowers87
dapowers87 previously approved these changes Jun 28, 2022
Signed-off-by: Dinu John <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #1547 (da71db3) into main (d737daf) will not change coverage.
The diff coverage is n/a.

❗ Current head da71db3 differs from pull request most recent head e48267c. Consider uploading reports for the commit e48267c to get more accurate results

@@            Coverage Diff            @@
##               main    #1547   +/-   ##
=========================================
  Coverage     94.18%   94.18%           
  Complexity     1181     1181           
=========================================
  Files           165      165           
  Lines          3386     3386           
  Branches        277      277           
=========================================
  Hits           3189     3189           
  Misses          141      141           
  Partials         56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d737daf...e48267c. Read the comment docs.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the documentation. I do think this is clearer.

@dinujoh dinujoh merged commit a233c9f into opensearch-project:main Jun 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
…1547)

* Enable HTTP Health Check for OTelTraceSource and OTelMetricsSource.
* Updated Readme file and added unit test for configurations

Signed-off-by: Dinu John <[email protected]>
(cherry picked from commit a233c9f)
dinujoh pushed a commit that referenced this pull request Jun 30, 2022
…1547) (#1549)

* Enable HTTP Health Check for OTelTraceSource and OTelMetricsSource.
* Updated Readme file and added unit test for configurations

Signed-off-by: Dinu John <[email protected]>
finnroblin pushed a commit to finnroblin/data-prepper that referenced this pull request Jul 11, 2022
…pensearch-project#1547)

* Enable HTTP Health Check for OTelTraceSource and OTelMetricsSource.
* Updated Readme file and added unit test for configurations

Signed-off-by: Dinu John <[email protected]>
Signed-off-by: Finn Roblin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants