Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Spotless 6.7.1 and removed JDK 17 work-around. #1506

Merged

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Jun 10, 2022

Description

Spotless 6.7.1 fixes an issue which made it incompatible with JDK 17. There was previously a work-around (which was applied in Data Prepper). This PR updates to the latest version of Spotless for Gradle and removes that old work-around.

diffplug/spotless#834 (comment)

For reference, the previous PR which added the work-around was #1430.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…JDK 17. Removed the work-around.

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable requested a review from a team as a code owner June 10, 2022 22:09
Copy link
Collaborator

@asifsmohammed asifsmohammed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dlvenable dlvenable merged commit e93a4bd into opensearch-project:main Jun 13, 2022
@dlvenable dlvenable deleted the spotless-jdk17-workaround-removal branch June 14, 2022 20:27
finnroblin pushed a commit to finnroblin/data-prepper that referenced this pull request Jul 11, 2022
…JDK 17. Removed the work-around. (opensearch-project#1506)

Signed-off-by: David Venable <[email protected]>
Signed-off-by: Finn Roblin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants