-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on Java 11 with Java 8 as the compilation toolchain #1406
Conversation
…hain for compilation. Updated GitHub Actions to build using Java 11 and for end-to-end tests, run Data Prepper against multiple versions of Java. Signed-off-by: David Venable <[email protected]>
… matrix. Signed-off-by: David Venable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1406 +/- ##
============================================
+ Coverage 94.08% 94.11% +0.02%
Complexity 1156 1156
============================================
Files 162 162
Lines 3248 3247 -1
Branches 263 263
============================================
Hits 3056 3056
+ Misses 138 137 -1
Partials 54 54
Continue to review full report at Codecov.
|
@@ -13,16 +13,16 @@ jobs: | |||
build: | |||
strategy: | |||
matrix: | |||
java: [14] | |||
java: [8, 11, 17] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this e2e also have JDK 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Prepper should support JDK 8. I think the question is, why do the other tests not have JDK 8. :)
Unfortunately there does seem to be a bug with TLS on JDK 8 for gRPC. That appears to be a general issue beyond this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought since the source code builds on JDK 8 and the tests build on JDK 11, 8 is omitted from other tests. Not a blocker for this PR.
Description
At a high-level, this PR adds a JDK 8 toolchain for compiling the Data Prepper main source code. It updates our GitHub Actions to build using Java 11.
Details:
Issues Resolved
Resolves #665
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.