Improve OpenSearch sink performance within the opensearch-java client #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r which avoids re-serializing bulk documents. Signed-off-by: David Venable <[email protected]>
asifsmohammed
approved these changes
May 13, 2022
chenqi0805
approved these changes
May 13, 2022
| Function<String, Record> stringModel = jsonString -> new Record(jsonString); | ||
| Function<String, Record> stringModel = jsonString -> { | ||
| try { | ||
| // Normalize the JSON string. |
There was a problem hiding this comment.
Why do we need the normalization?
There was a problem hiding this comment.
This is because of the assertions in the tests that assert the number of bytes written. The JSON is pretty formatted. So for Record<String> these are larger strings (and thus more bytes) than Record<Event>. The make the assertions later simpler, I just make all JSON non-pretty and thus the same byte size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent migration to the
opensearch-javaclient (#1381) introduced a performance migration which was caused by how the opensearch-java client serializes JSON data.This PR introduces a
PreSerializedJsonpMapperwhich will take a serialized JSON byte array and write that directly to the final OutputStream rather than serialize it. This has corrected Data Prepper's throughput to meet what 1.3 had.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.