Updated to Gradle 7 (version 7.4.2) #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t version. Signed-off-by: David Venable <[email protected]>
Signed-off-by: David Venable <[email protected]>
asifsmohammed
previously approved these changes
May 5, 2022
Comment on lines
1
to
4
| # | ||
| # Copyright OpenSearch Contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # |
There was a problem hiding this comment.
Isn't the copyright required for .properties files?
There was a problem hiding this comment.
I don't believe we should have it here because this is a file which was generated by Gradle itself.
There was a problem hiding this comment.
Though, it does appear that the OpenSearch core project includes it.
There was a problem hiding this comment.
@asifsmohammed , I added the header back to match what OpenSearch core does.
Signed-off-by: David Venable <[email protected]>
asifsmohammed
approved these changes
May 6, 2022
sbayer55
approved these changes
May 6, 2022
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-bin.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the project to Gradle 7.
Issues Resolved
Resolves #662
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.