Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: temporarily allow output generic object type #1192

Conversation

chenqi0805
Copy link
Collaborator

@chenqi0805 chenqi0805 commented Mar 14, 2022

Signed-off-by: Chen [email protected]

Description

This is a temporary fix on #1075 since we cannot get permanent fix #546 merged in for the upcoming release.

Issues Resolved

Resolves #1075

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@chenqi0805 chenqi0805 requested a review from a team as a code owner March 14, 2022 21:46
@chenqi0805 chenqi0805 requested review from sshivanii and a team March 14, 2022 22:17
@codecov-commenter
Copy link

Codecov Report

Merging #1192 (d0f7e3e) into main (87930eb) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1192      +/-   ##
============================================
+ Coverage     94.07%   94.19%   +0.12%     
  Complexity     1075     1075              
============================================
  Files           142      142              
  Lines          3055     3051       -4     
  Branches        277      275       -2     
============================================
  Hits           2874     2874              
+ Misses          130      128       -2     
+ Partials         51       49       -2     
Impacted Files Coverage Δ
.../com/amazon/dataprepper/plugins/sink/FileSink.java 87.50% <100.00%> (+6.73%) ⬆️
...om/amazon/dataprepper/plugins/sink/StdOutSink.java 100.00% <100.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87930eb...d0f7e3e. Read the comment docs.

@chenqi0805 chenqi0805 merged commit 4229dcc into opensearch-project:main Mar 15, 2022
@chenqi0805 chenqi0805 deleted the fix/1075-dump-generic-object-in-file-and-stdout-sink branch March 15, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't dump OTEL traces to stdout or file Migrate Trace Analytics Plugins to Event Model
4 participants