Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where Spring was unable to find the PrometheusMeterRegistry Bean #1019

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

graytaylor0
Copy link
Member

@graytaylor0 graytaylor0 commented Feb 9, 2022

Signed-off-by: graytaylor0 [email protected]

Description

  • The Data Prepper Server was unable to find the PrometheusMeterRegistry Bean, which resulted in the metrics core api endpoints being unavailable.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@graytaylor0 graytaylor0 requested a review from a team as a code owner February 9, 2022 17:42
@codecov-commenter
Copy link

Codecov Report

Merging #1019 (df9c74c) into main (69e1049) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1019   +/-   ##
=========================================
  Coverage     91.36%   91.36%           
  Complexity      683      683           
=========================================
  Files            84       84           
  Lines          1993     1993           
  Branches        168      168           
=========================================
  Hits           1821     1821           
  Misses          132      132           
  Partials         40       40           
Impacted Files Coverage Δ
...mazon/dataprepper/parser/config/MetricsConfig.java 79.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e1049...df9c74c. Read the comment docs.

@graytaylor0 graytaylor0 merged commit 57b403b into opensearch-project:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants