Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the @Deprecated from Record #3536

Closed
dlvenable opened this issue Oct 20, 2023 · 0 comments · Fixed by #3540
Closed

Remove the @Deprecated from Record #3536

dlvenable opened this issue Oct 20, 2023 · 0 comments · Fixed by #3540
Assignees
@dlvenable
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Milestone
v2.6

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

We deprecated the Record class, but have not provided any alternatives to users. Thus, developers ignore deprecation warnings, which is probably not what we want.

Also, might Record be useful for binary data?

Describe the solution you'd like

For now, remove the @Deprecated annotation from Record. We can circle back to this when we have an interest in consolidating entirely on Event.

Describe alternatives you've considered (Optional)

Keep this @Deprecated. But this is confusing to new developers.

Additional context

#944
@dlvenable dlvenable added the maintenance Issues to help maintain the project, such as improving builds, testing, etc. label Oct 20, 2023
@dlvenable dlvenable self-assigned this Oct 23, 2023
dlvenable added a commit to dlvenable/data-prepper that referenced this issue Oct 23, 2023
@dlvenable
Removed the deprecated annotation from Record and RecordMetadata as t…
2b740cf 
…hese are currently still very necessary. Resolves opensearch-project#3536.

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable mentioned this issue Oct 23, 2023
Merged
4 tasks
@dlvenable dlvenable added this to the v2.6 milestone Oct 23, 2023
dlvenable added a commit that referenced this issue Oct 23, 2023
@dlvenable
Removed the deprecated annotation from Record and RecordMetadata as t…
2f8372b 
…hese are currently still very necessary. Resolves #3536. (#3540)

Signed-off-by: David Venable <[email protected]>
@github-project-automation github-project-automation bot moved this from Unplanned to Done in Data Prepper Tracking Board Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlvenable dlvenable

Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Data Prepper Tracking Board
Archived in project
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Removes the deprecated annotation from Record and RecordMetadata dlvenable/data-prepper
1 participant
@dlvenable