Support building on JDK 17 #1430
Conversation
…run successfully on JDK 17. This change allows developers to build Data Prepper using JDK 17. Updated the Spotless Gradle plugin, which also allows us to remove an older work-around related to cleaning the project root build directory. Signed-off-by: David Venable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
=========================================
Coverage 94.23% 94.23%
Complexity 1174 1174
=========================================
Files 165 165
Lines 3366 3366
Branches 275 275
=========================================
Hits 3172 3172
Misses 138 138
Partials 56 56 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Let's update the developer guide too. It's a little out date now that we support building on JDK17.
https://github.com/opensearch-project/data-prepper/blob/main/docs/developer_guide.md
…th either JDK 11 or 17. Run the Gradle build and performance test builds on JDK 11 and 17 as part of the GitHub Actions CI. Signed-off-by: David Venable <[email protected]>
Thanks for the comment. I updated the documentation. |
|
I also added JDK 17 to two of the CI builds to help ensure that Data Prepper can continue to build against both JDK 11 and 17. |
Description
Building Data Prepper on JDK 17 failed with an error from Spotless. This PR resolves this by providing a workaround suggested by the Spotless team.
Additionally, update to the latest version of the Spotless Gradle plugin. Older versions prevented the
cleantask from working correctly for the root build directory. With this update, we can clean up an unnecessarycleantask.Spotless fix:
diffplug/spotless#1179
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.