PR feedback - Use Optional to make code more readable.

Signed-off-by: David Venable <[email protected]>
opensearch-project · Sep 27, 2022 · 53ebb6c · 53ebb6c
1 parent d497df2
commit 53ebb6c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/...per-core/src/main/java/org/opensearch/dataprepper/parser/model/PipelineConfiguration.java b/...per-core/src/main/java/org/opensearch/dataprepper/parser/model/PipelineConfiguration.java
@@ -15,6 +15,7 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import java.util.stream.Collectors;
 
 public class PipelineConfiguration {
@@ -113,13 +114,17 @@ private List<PluginSetting> getProcessorsFromPluginModel(
 
 
     private static PluginSetting getPluginSettingFromPluginModel(final PluginModel pluginModel) {
-        final Map<String, Object> settingsMap = pluginModel.getPluginSettings();
-        return new PluginSetting(pluginModel.getPluginName(), settingsMap == null ? new HashMap<>() : settingsMap);
+        final Map<String, Object> settingsMap = Optional
+                .ofNullable(pluginModel.getPluginSettings())
+                .orElseGet(HashMap::new);
+        return new PluginSetting(pluginModel.getPluginName(), settingsMap);
     }
 
     private static RoutedPluginSetting getRoutedPluginSettingFromSinkModel(final SinkModel sinkModel) {
-        final Map<String, Object> settingsMap = sinkModel.getPluginSettings();
-        return new RoutedPluginSetting(sinkModel.getPluginName(), settingsMap == null ? new HashMap<>() : settingsMap, sinkModel.getRoutes());
+        final Map<String, Object> settingsMap = Optional
+                .ofNullable(sinkModel.getPluginSettings())
+                .orElseGet(HashMap::new);
+        return new RoutedPluginSetting(sinkModel.getPluginName(), settingsMap, sinkModel.getRoutes());
     }
 
     private Integer getWorkersFromPipelineModel(final PipelineModel pipelineModel) {

diff --git a/...ore/src/test/java/org/opensearch/dataprepper/parser/model/PipelineConfigurationTests.java b/...ore/src/test/java/org/opensearch/dataprepper/parser/model/PipelineConfigurationTests.java
@@ -206,7 +206,7 @@ void testInvalidDelayConfiguration() {
     @Test
     void testSinksWithRoutes() {
         final List<Collection<String>> orderedSinkRoutes = new ArrayList<>();
-        for (SinkModel sink : sinks) {
+        for (final SinkModel sink : sinks) {
             final Set<String> routes = Collections.singleton(UUID.randomUUID().toString());
             when(sink.getRoutes()).thenReturn(routes);
             orderedSinkRoutes.add(routes);