Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url parsing #353

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

rupal-bq
Copy link
Contributor

@rupal-bq rupal-bq commented May 7, 2024

Description

Check if URL has # before split

Issues Resolved

#281

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal Mahajan <[email protected]>
@rupal-bq rupal-bq merged commit 105f68c into opensearch-project:main May 7, 2024
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 7, 2024
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit 105f68c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq pushed a commit that referenced this pull request May 7, 2024
(cherry picked from commit 105f68c)

Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants