Add workflow to verify binary installation is successful #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 30 30
Lines 1904 1904
Branches 410 410
=======================================
Hits 1418 1418
Misses 483 483
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
YANG-DB
approved these changes
Feb 23, 2024
rupal-bq
approved these changes
Feb 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add workflow to verify binary installation is successful Signed-off-by: Derek Ho <[email protected]> * Use new version to pass in custom suffix Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit a9c0c95) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Add workflow to verify binary installation is successful * Use new version to pass in custom suffix --------- (cherry picked from commit a9c0c95) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.
Related issues:
opensearch-project/security-dashboards-plugin#1709
opensearch-project/security-analytics-dashboards-plugin#875
There was also an issue in this repo that was fixed when we caught a similar issue during release testing. Context is here: opensearch-project/dashboards-observability#309. Here is a test run proving this PR would have caught that issue during RC testing: https://github.com/opensearch-project/dashboards-observability/actions/runs/8024893403/job/21924379904
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.