Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add single version flag during bootstrap to fix version conflicts #269

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

RyanL1997
Copy link
Contributor

Description

On behalf of the change in dashboards core: opensearch-project/OpenSearch-Dashboards#5675. We need to add --single-version=loose flag during the bootstrap step in our CI to manipulate the behavior of single-version validation.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (236db60) 53.04% compared to head (f67ab3c) 59.88%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   53.04%   59.88%   +6.83%     
==========================================
  Files          33       33              
  Lines        1623     1623              
  Branches      288      288              
==========================================
+ Hits          861      972     +111     
+ Misses        674      548     -126     
- Partials       88      103      +15     
Flag Coverage Δ
dashboards-query-workbench 59.88% <ø> (+6.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 merged commit 9188921 into opensearch-project:main Feb 19, 2024
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 19, 2024
…icts (#269)

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 9188921)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Feb 24, 2024
…icts (#269) (#270)

(cherry picked from commit 9188921)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants