Fix jest tests #255
Merged
Fix jest tests #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha and
paulstn
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 53.04% 59.88% +6.83%
==========================================
Files 33 33
Lines 1623 1623
Branches 288 288
==========================================
+ Hits 861 972 +111
+ Misses 674 548 -126
- Partials 88 103 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Feb 1, 2024
YANG-DB
approved these changes
Feb 1, 2024
mengweieric
reviewed
Feb 1, 2024
| @@ -2181,3 +2196,206 @@ export const mockOpenSearchTreeQuery = { | |||
| '{"schema":[{"name":"TABLE_CAT","type":"keyword"},{"name":"TABLE_SCHEM","type":"keyword"},{"name":"TABLE_NAME","type":"keyword"},{"name":"TABLE_TYPE","type":"keyword"},{"name":"REMARKS","type":"keyword"},{"name":"TYPE_CAT","type":"keyword"},{"name":"TYPE_SCHEM","type":"keyword"},{"name":"TYPE_NAME","type":"keyword"},{"name":"SELF_REFERENCING_COL_NAME","type":"keyword"},{"name":"REF_GENERATION","type":"keyword"}],"datarows":[["opensearch-cluster",null,".kibana_1","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".opendistro-job-scheduler-lock","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".opendistro-reports-definitions","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".opendistro-reports-instances","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".opendistro_security","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".opensearch-observability","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".plugins-ml-config","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".ql-datasources","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"jaeger-service-2023-01-24","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"jaeger-span-2023-01-24","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"opensearch_dashboards_sample_data_ecommerce","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"opensearch_dashboards_sample_data_flights","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"opensearch_dashboards_sample_data_logs","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"otel-v1-apm-service-map","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"otel-v1-apm-span-000001","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"otel-v1-apm-span-000002","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"sample-ecommerce","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"sample-host-health","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"sample-http-responses","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.16","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.17","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.18","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.19","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.20","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.21","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.22","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.23","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.24","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"security-auditlog-2023.10.25","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"windows","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,".kibana","BASE TABLE",null,null,null,null,null,null],["opensearch-cluster",null,"s3--pWlOosB5t9LzIj0oUsS","BASE TABLE",null,null,null,null,null,null]],"total":32,"size":32,"status":200}', | |||
| }, | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
This file grows so large, we can do proper breakdown later but wondering if we can move these testing data to another file or even a json file. Keep adding these large piece of data will make it harder and harder to maintain
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* cypress tests Signed-off-by: sumukhswamy <[email protected]> * changed config for the test to dump data Signed-off-by: sumukhswamy <[email protected]> * added jest tests Signed-off-by: sumukhswamy <[email protected]> * added a few changes for comments Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 5c06b27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Feb 6, 2024
* cypress tests * changed config for the test to dump data * added jest tests * added a few changes for comments * updated snapshots --------- (cherry picked from commit 5c06b27) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added jest tests to increase code coverage and fixed flakey tests in cypress
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.