Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add eslint workflow #244

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

RyanL1997
Copy link
Contributor

Description

Add eslint workflow

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <[email protected]>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e1f256) 53.76% compared to head (a0186b1) 53.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   53.76%   53.76%           
=======================================
  Files          33       33           
  Lines        1622     1622           
  Branches      288      288           
=======================================
  Hits          872      872           
  Misses        662      662           
  Partials       88       88           
Flag Coverage Δ
dashboards-query-workbench 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48
Copy link
Member

ps48 commented Jan 11, 2024

@RyanL1997 Can you please update the snapshots from the upstream change?

Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997
Copy link
Contributor Author

Thanks for reminding @ps48. The snapshots has been updated.

@ps48 ps48 merged commit 6408277 into opensearch-project:main Jan 16, 2024
11 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 16, 2024
* Add eslint command

Signed-off-by: Ryan Liang <[email protected]>

* Update snapshot

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 6408277)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Jan 18, 2024
* [CI/CD] Add eslint workflow (#244)

* Add eslint command

Signed-off-by: Ryan Liang <[email protected]>

* Update snapshot

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 6408277)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* 2.x changes

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Eric <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants