-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync dependencies to the latest versions #241
Conversation
Signed-off-by: Ryan Liang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 53.08% 53.76% +0.67%
==========================================
Files 33 33
Lines 1622 1622
Branches 288 288
==========================================
+ Hits 861 872 +11
+ Misses 673 662 -11
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Liang <[email protected]>
^13.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Why is snapshot failing? |
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
For reference, the snapshots test would fail like this: https://github.com/opensearch-project/dashboards-query-workbench/actions/runs/7452711838/job/20276572778?pr=241#step:5:328 without the update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot updates look like they're checking loaded components now instead of loading ones. I checked the tests and it doesn't look like any of these should be on a loading component, so I'm wondering why the snapshot was made with a loading state at all. This seems like maybe a silent rendering bugfix with the react update? Poked around the changelog and didn't see any obvious candidates.
I'm inclined to merge this if there's not a clear reason we need the components to remain loading in the snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanL1997 Can you please add the backport label to 2.x?
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.x
# Create a new branch
git switch --create backport/backport-241-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4e1f2560662bc718ef19aed52055207b10efdbab
# Push it to GitHub
git push --set-upstream origin backport/backport-241-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.x Then, create a pull request where the |
I will manually backport this |
* Sync Cypress version to 13.6.0 Signed-off-by: Ryan Liang <[email protected]> * Sync all the dependencies with latest versions Signed-off-by: Ryan Liang <[email protected]> * Add yarn lock changes Signed-off-by: Ryan Liang <[email protected]> * Update snapshots Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
* Sync Cypress version to 13.6.0 * Sync all the dependencies with latest versions * Add yarn lock changes * Update snapshots --------- Signed-off-by: Ryan Liang <[email protected]>
Description
Due to the failure of version conflict for security dashboards plugin's distribution build: https://github.com/opensearch-project/security-dashboards-plugin/blob/7cad47c38478646cd96f0eb1623b77acd853b803/package.json#L30
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.