Fix error handling for user w/o proper permissions (#195)

* fix error handling for user w/o indices access Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 03b1824) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Oct 31, 2023 · 732203d · 732203d
1 parent 09cc788
commit 732203d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/public/components/Main/__snapshots__/main.test.tsx.snap b/public/components/Main/__snapshots__/main.test.tsx.snap
@@ -2381,7 +2381,7 @@ exports[`<Main /> spec click run button, and response causes an error 1`] = `
                       class="euiText euiText--medium"
                     >
                       <p>
-                        err
+                        Error in loading OpenSearch indices
                       </p>
                     </div>
                   </span>

diff --git a/public/components/SQLPage/table_view.tsx b/public/components/SQLPage/table_view.tsx
@@ -112,7 +112,7 @@ export const TableView = ({ http, selectedItems, updateSQLQueries, refreshTree }
           body: JSON.stringify(query),
         })
         .then((res) => {
-          const responseObj = res.data.resp ? JSON.parse(res.data.resp) : {};
+          const responseObj = JSON.parse(res.data.resp);
           const dataRows: any[][] = _.get(responseObj, 'datarows');
           if (dataRows.length > 0) {
             const fields = dataRows.map((data) => {
@@ -131,9 +131,9 @@ export const TableView = ({ http, selectedItems, updateSQLQueries, refreshTree }
           console.error(err);
           setIsLoading({
             flag: false,
-            status: err,
+            status: 'Error in loading OpenSearch indices',
           });
-          setToast(`ERROR ${err}`, 'danger');
+          setToast(`Error in loading OpenSearch indices, please check user permissions`, 'danger');
         });
     } else {
       setTableNames([]);
@@ -536,7 +536,7 @@ export const TableView = ({ http, selectedItems, updateSQLQueries, refreshTree }
                     {node.type === TREE_ITEM_TABLE_NAME_DEFAULT_NAME && !node.isLoading && (
                       <EuiIcon
                         type="editorCodeBlock"
-                        onClick={(e) => handleQuery(e,parentName,node.name)}
+                        onClick={(e) => handleQuery(e, parentName, node.name)}
                       ></EuiIcon>
                     )}
                   </EuiText>
-Original file line number
+Diff line change
@@ Expand Up @@
                           class="euiText euiText--medium"
                         >
                           <p>
-                            err
+                            Error in loading OpenSearch indices
                           </p>
                         </div>
                       </span>
@@ Expand Down @@