Recover Panel View Legacy - Duplicate Action #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panel View SavedObject - Duplicate Action - protect render from invalid record - hide render while loading Signed-off-by: Peter Fitzgibbons <[email protected]>
pjfitzgibbons
requested review from
anirudha,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings and
Swiddis
as code owners
anirudha
approved these changes
Apr 17, 2023
mengweieric
approved these changes
Apr 17, 2023
ps48
approved these changes
Apr 17, 2023
joshuali925
approved these changes
Apr 17, 2023
| panelList: [], | ||
| loadingFlag: false, |
| @@ -600,7 +581,9 @@ export const CustomPanelViewSO = (props: CustomPanelViewProps) => { | |||
| chrome.setBreadcrumbs([...parentBreadcrumbs, ...newBreadcrumb]); | |||
| }, [panelId, panel]); | |||
|
|
|||
| return ( | |||
| return loading ? ( | |||
| <></> | |||
There was a problem hiding this comment.
n.p. no need for empty fragment, null should be enough
pjfitzgibbons
added a commit
that referenced
this pull request
Apr 18, 2023
Panel View SavedObject - Duplicate Action - protect render from invalid record - hide render while loading Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]>
pjfitzgibbons
added a commit
that referenced
this pull request
Apr 18, 2023
Panel View SavedObject - Duplicate Action - protect render from invalid record - hide render while loading Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit 529623e)
joshuali925
pushed a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
Panel View SavedObject - Duplicate Action - protect render from invalid record - hide render while loading Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panel View SavedObject
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.