Fix crash at loading app analytics tabs #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
pjfitzgibbons,
anirudha,
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings and
Swiddis
as code owners
rupal-bq
reviewed
Apr 17, 2023
| Array [ | ||
| undefined, | ||
| Object { | ||
| "href": "#/trace_analytics/home", |
There was a problem hiding this comment.
is trace_analytics in url works? I thought it was removed in earlier pr
There was a problem hiding this comment.
that is probably from test files
The unit test doesn't care what it should be in reality, as long as dummy arguments are all valid it serves its purpose
Signed-off-by: Joshua Li <[email protected]>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Joshua Li <[email protected]>
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 6f13761) Signed-off-by: Peter Fitzgibbons <[email protected]>
joshuali925
added a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Joshua Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For future refactoring: it would be better to use core chrome service to get current breadcrumbs, then append new ones to it, rather than passing down parentBreadcrumbs as props.
Passing parent down can be inconsistent (this case breadcrumb vs array) and redundant
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.