Reorganize 3_panels.spec.ts E2E #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in preparation of PR #361 Signed-off-by: Peter Fitzgibbons <[email protected]>
pjfitzgibbons
requested review from
anirudha,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings and
Swiddis
as code owners
|
Renamed Branch |
joshuali925
approved these changes
Apr 17, 2023
pjfitzgibbons
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]> (cherry picked from commit c52b3a1) Signed-off-by: Peter Fitzgibbons <[email protected]>
joshuali925
pushed a commit
to joshuali925/dashboards-observability
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Peter Fitzgibbons <[email protected]> Co-authored-by: Peter Fitzgibbons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #361 is a large fix to Panels Duplication and the associated E2E test.
In order to simplify the review of the E2E test ,this reorganization of 3_panels_spec.ts, including new
describe()sections, results in a large formatting-only PR and will simplify the subsequent change.#361 will be temporarily based upon this branch for continued review until this PR is merged.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.