Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Explorer sidebar refactoring #326

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Mar 15, 2023

Description

Sidebar related refactoring

  • move fields toggling functions to under sidebar component rather than under explorer.tsx
  • fix a bug -> when switching to a different index, previous selected fields still shows up under selected fields
    • currently any new refresh button click to trigger a search would clear out the selected fields if there are any, as it does not yet have the capability to detect index change for updating fields accordingly. To add such index difference detection would add to data fetching flow which is under refactoring. We may need to add support to update all fields only when index changes
  • update tests/snapshots

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric mengweieric marked this pull request as ready for review March 15, 2023 18:05
@mengweieric mengweieric requested a review from a team as a code owner March 15, 2023 18:05
@mengweieric mengweieric merged commit 13eccbb into opensearch-project:main Mar 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
* move fields toggle from explorer to under sidebar

Signed-off-by: Eric Wei <[email protected]>

* fix the bug when switching index seeing fields from old index

Signed-off-by: Eric Wei <[email protected]>

* update tests/snapshots

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 13eccbb)
mengweieric added a commit that referenced this pull request Mar 16, 2023
* move fields toggle from explorer to under sidebar

Signed-off-by: Eric Wei <[email protected]>

* fix the bug when switching index seeing fields from old index

Signed-off-by: Eric Wei <[email protected]>

* update tests/snapshots

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 13eccbb)

Co-authored-by: Eric Wei <[email protected]>
derek-ho pushed a commit to derek-ho/dashboards-observability that referenced this pull request Apr 5, 2023
* move fields toggle from explorer to under sidebar

Signed-off-by: Eric Wei <[email protected]>

* fix the bug when switching index seeing fields from old index

Signed-off-by: Eric Wei <[email protected]>

* update tests/snapshots

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
@mengweieric mengweieric deleted the sidebar-refactoring branch February 14, 2024 18:29
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#328)

* move fields toggle from explorer to under sidebar

Signed-off-by: Eric Wei <[email protected]>

* fix the bug when switching index seeing fields from old index

Signed-off-by: Eric Wei <[email protected]>

* update tests/snapshots

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 13eccbb)

Co-authored-by: Eric Wei <[email protected]>
(cherry picked from commit bc71ed3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants