Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] move performance now to run time dep (#309) #311

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Feb 23, 2023

  • move performance now to run time dep

Signed-off-by: Derek Ho [email protected]

  • update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho [email protected]


Signed-off-by: Derek Ho [email protected]
(cherry picked from commit c046499)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* move performance now to run time dep

Signed-off-by: Derek Ho <[email protected]>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit c046499)
@ps48 ps48 requested a review from a team as a code owner February 23, 2023 22:20
package.json Outdated
@@ -48,7 +49,7 @@
"husky": "6.0.0",
"jest-dom": "^4.0.0",
"lint-staged": "^13.1.0",
"performance-now": "^2.1.0"
"jest-dom": "^4.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no code change for adding jest-dom?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like 2 'jest-dom' exists

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ps48 can you remove the extra dep? I just checked the original PR doesn't have this might have happened during merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplication arose due to auto-merge in cherry pick. Fixed it.

ps48 added 2 commits March 27, 2023 10:36
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 merged commit 80b1a9f into main Mar 27, 2023
@github-actions github-actions bot deleted the backport/backport-309-to-main branch March 27, 2023 20:03
mengweieric pushed a commit that referenced this pull request Apr 3, 2023
* move performance now to run time dep (#309)

* move performance now to run time dep

Signed-off-by: Derek Ho <[email protected]>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit c046499)

* remove duplicate jest-dom

Signed-off-by: Shenoy Pratik <[email protected]>

* updated snapshots for notebooks

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
derek-ho added a commit to derek-ho/dashboards-observability that referenced this pull request Apr 5, 2023
…ect#309) (opensearch-project#311)

* move performance now to run time dep (opensearch-project#309)

* move performance now to run time dep

Signed-off-by: Derek Ho <[email protected]>

* update release notes for this PR and CI fix PR

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit c046499)

* remove duplicate jest-dom

Signed-off-by: Shenoy Pratik <[email protected]>

* updated snapshots for notebooks

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants