Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix SQL/PPL crash with incorrect query #2284

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Dec 6, 2024

Description

Fix SQL/PPL crash with incorrect query

Issues Resolved

  • Notebooks crash when an Incorrect query is added to a paragraph.
  • Added a test to check incorrect query results on PPL and SQL

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 added 2 commits December 6, 2024 10:50
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 added bug Something isn't working backport 2.x notebooks labels Dec 6, 2024
@ps48 ps48 merged commit d0f0012 into opensearch-project:main Dec 9, 2024
19 of 24 checks passed
@ps48 ps48 added the mds-2.18.0 label Dec 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2024
* fix SQL/PPL crash with incorrect query

Signed-off-by: Shenoy Pratik <[email protected]>

* add constants

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit d0f0012)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Dec 9, 2024
* fix SQL/PPL crash with incorrect query



* add constants



---------


(cherry picked from commit d0f0012)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants