Fix fetching workspace visualizations error #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
ps48
changed the title
RyanL1997
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Hi @raintygao, thanks for taking this on. Can we add some tests for this?
Signed-off-by: tygao <[email protected]>
ps48
approved these changes
Dec 5, 2024
|
Thanks for the fix and adding the tests. |
TackAdam
approved these changes
Dec 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
* fix: fix fetching workspace visualizations error Signed-off-by: tygao <[email protected]> * fix: fix fetching workspace visualizations error Signed-off-by: tygao <[email protected]> * test: add unit tests Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit b418d44) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
added a commit
that referenced
this pull request
Dec 6, 2024
* fix: fix fetching workspace visualizations error * fix: fix fetching workspace visualizations error * test: add unit tests --------- (cherry picked from commit b418d44) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix fetching workspace visualizations error
When fetching visualizations, we don't need to append workspace field manually to fetch current workspace visualizations, especially not workspace name, it will cause the request failed.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.