Remove fallback restore keys from build cache #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
RyanL1997
approved these changes
Oct 31, 2024
|
Lets get more reviews and close this. cc @mengweieric @ps48 @joshuali925 |
ps48
approved these changes
Dec 4, 2024
|
@Swiddis @RyanL1997 Does this need to be backported to 2.x? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Jialiang Liang <[email protected]> (cherry picked from commit c1f5cce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit c1f5cce) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jialiang Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache seems to be in a bad state and isn't being regenerated due to fallback keys loading older caches. I'm not sure why the cache is in a bad state to begin with (does this need to be an issue upstream?) but this workaround should do the trick for now.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.