[BUG]Re direction fix for associated logs from traces #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
joshuali925
approved these changes
Oct 19, 2024
| props.dataSourceMDSId[0].id ?? '' | ||
| }::ss4o_logs-*',timeFieldName:'time',title:'ss4o_logs-*',type:INDEXES),language:PPL,query:'source%20%3D%20ss4o_logs-%2A%20%7C%20where%20serviceName%20%3D%20%22${ | ||
| props.serviceName | ||
| }%22'))`, |
There was a problem hiding this comment.
todo for the future, it would be better to use rison encode and url encode, instead of hard coding string concatenation
| @@ -307,9 +308,9 @@ export function SpanDetailFlyout(props: { | |||
| props.startTime | |||
| },to:${props.endTime}))&_q=(filters:!(),query:(dataset:(dataSource:(id:'${ | |||
There was a problem hiding this comment.
TODO the timestamps are currently undefined, need to pass them into props from parent
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
force-pushed
the
re-direction-fix
branch
from
78c0243 to
0b00ea0
Compare
mengweieric
approved these changes
Oct 19, 2024
vamsimanohar
approved these changes
Oct 19, 2024
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
force-pushed
the
re-direction-fix
branch
from
72f5946 to
8edad7d
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2024
* updated paths for re-direction Signed-off-by: sumukhswamy <[email protected]> * updated paths for re-direction Signed-off-by: sumukhswamy <[email protected]> * updated the title without quotes Signed-off-by: sumukhswamy <[email protected]> * updated linter Signed-off-by: sumukhswamy <[email protected]> * updated snapshots Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 46ec7f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Oct 19, 2024
* updated paths for re-direction * updated paths for re-direction * updated the title without quotes * updated linter * updated snapshots --------- (cherry picked from commit 46ec7f2) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remote cluster title and time bug for redirection to Discover
Bug from PR #2201
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.