Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add compile step before Cypress runs in CI #2189

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Backport 2.x] Add compile step before Cypress runs in CI #2189

merged 2 commits into from
Oct 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fb9027a from #2187.

@github-actions
Add compile step before Cypress runs in CI (#2187)
ca9ee00 
* Add compile step before run step

Signed-off-by: Simeon Widdis <[email protected]>

* Remove wait-for-startup step

Signed-off-by: Simeon Widdis <[email protected]>

* Fix detection of server startup

Signed-off-by: Simeon Widdis <[email protected]>

* Fix cache finding no lock files

Signed-off-by: Simeon Widdis <[email protected]>

* Add caches for different package targets

Signed-off-by: Simeon Widdis <[email protected]>

* Fix caches

Signed-off-by: Simeon Widdis <[email protected]>

* Add yarn cache to regular unit tests

Signed-off-by: Simeon Widdis <[email protected]>

* Remove target cache in ftr

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit fb9027a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
derek-ho approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RyanL1997
Copy link
Collaborator

Found:

Error: Exception in thread "main" java.io.IOException: Error reading Zip content from /tmp/16803206643295481269.zip
-> Rolling back file:/home/runner/work/dashboards-observability/dashboards-observability/plugin-artifacts/observability.zip
	at org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:872)
	at org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:931)
	at org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:819)
	at org.opensearch.plugins.InstallPluginCommand.unzip(InstallPluginCommand.java:719)
	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:274)
	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:[25](https://github.com/opensearch-project/dashboards-observability/actions/runs/11240946120/job/31251403700?pr=2189#step:11:26)0)
	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
	at org.opensearch.cli.Command.main(Command.java:101)
	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)
Caused by: java.util.zip.ZipException: Archive is not a ZIP archive
	at org.apache.commons.compress.archivers.zip.ZipFile.positionAtEndOfCentralDirectoryRecord(ZipFile.java:562)
	at org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:1299)
	at org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:1[27](https://github.com/opensearch-project/dashboards-observability/actions/runs/11240946120/job/31251403700?pr=2189#step:11:28)4)
	at org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:865)
	... 11 more
-> Rolled back file:/home/runner/work/dashboards-observability/dashboards-observability/plugin-artifacts/observability.zip
yes: standard output: Broken pipe
Error: Process completed with exit code 1.

in CI run: https://github.com/opensearch-project/dashboards-observability/actions/runs/11240946670/job/31251405417?pr=2189

@Swiddis
Copy link
Collaborator

Swiddis commented Oct 9, 2024

Looks like that error is affecting all 2.x backports, unrelated to this PR

@Swiddis Swiddis merged commit 3336233 into 2.x Oct 9, 2024
14 of 30 checks passed
@Swiddis Swiddis deleted the backport/backport-2187-to-2.x branch October 9, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiddis Swiddis Swiddis approved these changes

@derek-ho derek-ho derek-ho approved these changes

@ps48 ps48 ps48 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@TackAdam TackAdam Awaiting requested review from TackAdam TackAdam is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanL1997 @Swiddis @ps48 @derek-ho