Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Header] New page header for integrations and UI updates #2103

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Aug 28, 2024

Description

New page header for integration and ui updates

Old Navigation:

Before After
Before Image 1 After Image 1
Before Image 2 After Image 2
Before Image 3 After Image 3
Before Image 4 After Image 4
Before Image 5 After Image 5

New Navigation:

Before After
Before Image 1 After Image 1
Before Image 2 After Image 2
Before Image 3 After Image 3
Before Image 4 After Image 4
Before Image 5 After Image 5

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Aug 28, 2024
@TackAdam TackAdam marked this pull request as ready for review August 28, 2024 16:09
<EuiSmallButton onClick={onShowUpload} fill>
Upload Integration
</EuiSmallButton>
</EuiFlexItem>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

public/plugin.tsx Outdated Show resolved Hide resolved
@TackAdam TackAdam merged commit c655eb5 into opensearch-project:main Aug 28, 2024
10 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
* new headers and ui changes for integrations

Signed-off-by: Adam Tackett <[email protected]>

* update snapshots and test

Signed-off-by: Adam Tackett <[email protected]>

* update display name for integration breadcrumb for new nav rendering

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit c655eb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam pushed a commit that referenced this pull request Aug 28, 2024
…2107)

* new headers and ui changes for integrations



* update snapshots and test



* update display name for integration breadcrumb for new nav rendering



---------



(cherry picked from commit c655eb5)

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants