[Look&Feel] Notebooks Density and Consistency Improvements #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldong51
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
TackAdam
approved these changes
Aug 20, 2024
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
l&f-notebooks
branch
from
6f8b892 to
1b698e9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
- Coverage 57.85% 54.75% -3.10%
==========================================
Files 372 394 +22
Lines 14081 15244 +1163
Branches 3712 4124 +412
==========================================
+ Hits 8146 8347 +201
- Misses 5871 6816 +945
- Partials 64 81 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
virajsanghvi
approved these changes
Aug 20, 2024
Swiddis
approved these changes
Aug 20, 2024
danieldong51
force-pushed
the
l&f-notebooks
branch
from
ceef45a to
6410853
Compare
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
l&f-notebooks
branch
from
ccb6bc5 to
9a5c390
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Updated Notebooks Look & Feel Signed-off-by: Dan Dong <[email protected]> * Fixed error Signed-off-by: Dan Dong <[email protected]> * Fixed error Signed-off-by: Dan Dong <[email protected]> * Fixed lint and cypress test errors Signed-off-by: Dan Dong <[email protected]> --------- Signed-off-by: Dan Dong <[email protected]> (cherry picked from commit 8ac7ea0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Aug 22, 2024
…2088) * Updated Notebooks Look & Feel * Fixed error * Fixed error * Fixed lint and cypress test errors --------- (cherry picked from commit 8ac7ea0) Signed-off-by: Dan Dong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the Look & Feel density and consistency changes to Notebooks:
Screenshots
Small context Menu
Paragraph size
Semantic Headers
Modals
Buttons
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.