Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Remove integrations from new NavGroups #1950

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 21, 2024

Description

Remove integrations from new NavGroups (security-analytics and analytics) and switch to new naming convention Visualize and Report
Screenshot 2024-07-21 at 3 47 24 PM
Screenshot 2024-07-22 at 2 40 45 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <[email protected]>
public/plugin.tsx Outdated Show resolved Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
@ps48
Copy link
Member

ps48 commented Jul 22, 2024

The snapshot failures are coming in from core.

@ps48 ps48 merged commit 0b472ec into opensearch-project:main Jul 22, 2024
9 of 19 checks passed
@ps48 ps48 added the enhancement New feature or request label Jul 22, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
* Remove integrations from new Nav

Signed-off-by: Adam Tackett <[email protected]>

* Integrations only in observability

Signed-off-by: Adam Tackett <[email protected]>

* Update snapshots

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 0b472ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
* Remove integrations from new Nav

Signed-off-by: Adam Tackett <[email protected]>

* Integrations only in observability

Signed-off-by: Adam Tackett <[email protected]>

* Update snapshots

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit 0b472ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Jul 22, 2024
* Remove integrations from new Nav



* Integrations only in observability



* Update snapshots



---------



(cherry picked from commit 0b472ec)

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <[email protected]>
ps48 pushed a commit that referenced this pull request Jul 22, 2024
* Remove integrations from new Nav



* Integrations only in observability



* Update snapshots



---------



(cherry picked from commit 0b472ec)

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants