[Backport 2.x][Navigation] Register all plugins to NavGroups (#1926) #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a function to register all plugin Nav groups and categories Signed-off-by: Adam Tackett <[email protected]> * Updated addNavLinkGroups path rename dashboards Signed-off-by: Adam Tackett <[email protected]> * Fixing Naming Signed-off-by: Adam Tackett <[email protected]> * feat: enable default route Signed-off-by: SuZhou-Joe <[email protected]> * Update breadcrumb for Trace to default to service page Signed-off-by: Adam Tackett <[email protected]> * Update snapshots Signed-off-by: Adam Tackett <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add some features to all use case Signed-off-by: SuZhou-Joe <[email protected]> * Depreciated logs, application. Dashboards/Traces adjusted Signed-off-by: Adam Tackett <[email protected]> * Not registering logs/applications/dashboards when left nav used Signed-off-by: Adam Tackett <[email protected]> * Update snapshots Signed-off-by: Adam Tackett <[email protected]> * fixing lint errors Signed-off-by: Adam Tackett <[email protected]> * Put applications back Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin_nav.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Update public/plugin.tsx Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> * Removed applications from new nav Signed-off-by: Adam Tackett <[email protected]> * Add applications back, remove in app nav for trace, remove breadcrumbs while new navigation is active Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Adam Tackett <[email protected]> * Adjust order of metrics/traces/services/applications as per guidance from kevin Signed-off-by: Adam Tackett <[email protected]> * function for nav breadcrumbs added Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: Sumukh Swamy <[email protected]> (cherry picked from commit 09090a6)
TackAdam
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
TackAdam
changed the title
mengweieric
approved these changes
Jul 19, 2024
sumukhswamy
approved these changes
Jul 19, 2024
ps48
reviewed
Jul 19, 2024
Signed-off-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: SuZhou-Joe [email protected]
Signed-off-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: Adam Tackett [email protected]
Signed-off-by: SuZhou-Joe [email protected]
Signed-off-by: Adam Tackett [email protected]
Co-authored-by: Adam Tackett [email protected]
Co-authored-by: SuZhou-Joe [email protected]
Co-authored-by: Sumukh Swamy [email protected]
(cherry picked from commit 09090a6)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.