[Bug Fix] Add mds support for routers and fix the missing callAsCurrentUser
#1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
changed the title
callAsCurrentUser
sumukhswamy
approved these changes
Jul 18, 2024
YANG-DB
approved these changes
Jul 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
- Coverage 57.85% 54.95% -2.90%
==========================================
Files 372 391 +19
Lines 14081 15137 +1056
Branches 3712 4052 +340
==========================================
+ Hits 8146 8319 +173
- Misses 5871 6739 +868
- Partials 64 79 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
changed the title
callAsCurrentUsercallAsCurrentUser
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…entUser` (#1942) * [MDS] Add mds support for routers Signed-off-by: Ryan Liang <[email protected]> * Fix the missing call as current user when mds is disabled Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit c2edf41) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
Jul 18, 2024
…entUser` (#1942) (#1944) * [MDS] Add mds support for routers * Fix the missing call as current user when mds is disabled --------- (cherry picked from commit c2edf41) Signed-off-by: Ryan Liang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
callAsCurrentUserfor router:${DATACONNECTIONS_BASE}/dataSourceMDSId={dataSourceMDSId?}Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.