Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove duplicate description for create s3 datasource flow #1915

Merged

Conversation

RyanL1997
Copy link
Collaborator

Description

Remove duplicate description for create s3 datasource flow

Issues Resolved

Before:
Screenshot 2024-06-18 at 2 00 48 PM

After:
Screenshot 2024-06-18 at 2 03 27 PM

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.93%. Comparing base (c3ab50f) to head (1fc534c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
- Coverage   57.85%   54.93%   -2.92%     
==========================================
  Files         372      391      +19     
  Lines       14081    15137    +1056     
  Branches     3712     4058     +346     
==========================================
+ Hits         8146     8316     +170     
- Misses       5871     6741     +870     
- Partials       64       80      +16     
Flag Coverage Δ
dashboards-observability 54.93% <ø> (-2.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 47e8578 into opensearch-project:main Jun 24, 2024
15 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 24, 2024
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 47e8578)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Jun 25, 2024
…1923)

(cherry picked from commit 47e8578)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants