Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added placeholder change for metrics picker #1906

Merged
merged 4 commits into from
Jun 12, 2024
Merged

added placeholder change for metrics picker #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5353ab
added placeholder change for metrics picker
sumukhswamy Jun 12, 2024
8b4a61b
updated release notes
sumukhswamy Jun 12, 2024
b3b3297
updated tests
sumukhswamy Jun 12, 2024
7e9da71
Merge branch 'main' into fix-placeholder
sumukhswamy Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
},
]
}
placeholder="Select a data source"
placeholder="Select a metric source"
selectedOptions={Array []}
singleSelection={
Object {
Expand Down Expand Up @@ -216,7 +216,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
onFocus={[Function]}
onOpenListClick={[Function]}
onRemoveOption={[Function]}
placeholder="Select a data source"
placeholder="Select a metric source"
rootId={[Function]}
searchValue=""
selectedOptions={Array []}
Expand Down Expand Up @@ -259,7 +259,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
<p
className="euiComboBoxPlaceholder"
>
Select a data source
Select a metric source
</p>
<AutosizeInput
aria-controls=""
Expand Down
6 changes: 3 additions & 3 deletions public/components/metrics/sidebar/data_source_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const DataSourcePicker = ({
selectedDataSource,
setSelectedDataSource,
}: DataSourcePickerMenuProps) => {
const onChange = (selectedDataSource) => {
setSelectedDataSource(selectedDataSource);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter issue

const onChange = (selectedMetricSource) => {
setSelectedDataSource(selectedMetricSource);
};

return (
Expand All @@ -27,7 +27,7 @@ export const DataSourcePicker = ({
<h5>Metrics source</h5>
</EuiTitle>
<EuiComboBox
placeholder="Select a data source"
placeholder="Select a metric source"
singleSelection={{ asPlainText: true }}
options={DATASOURCE_OPTIONS}
selectedOptions={selectedDataSource || []}
Expand Down
1 change: 1 addition & 0 deletions release-notes/dashboards-observability.release-notes-2.15.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 2.15.0
* [Bug fix] Add conditional rendering for data connection page's tabs ([#1756](https://github.com/opensearch-project/dashboards-observability/pull/1756))
* removed update button from explorer ([#1755](https://github.com/opensearch-project/dashboards-observability/pull/1755))
* (query assist) remove caching agent id ([#1734](https://github.com/opensearch-project/dashboards-observability/pull/1734))
* added placeholder change for metrics picker ([#1906](https://github.com/opensearch-project/dashboards-observability/pull/1906))

### Maintenance
* Remove mocha from dependencies ([#1890](https://github.com/opensearch-project/dashboards-observability/pull/1890))
Expand Down
Loading