Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15 release notes #1900

Merged
merged 1 commit into from
Jun 11, 2024
Merged

2.15 release notes #1900

merged 1 commit into from
Jun 11, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jun 11, 2024

Description

Notes, generated with my script

Issues Resolved

No notes

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice script. i did something similar a long time ago but based on copied text from github web, used it until github UI updated.. this is more robust

@Swiddis Swiddis merged commit dbf6738 into opensearch-project:main Jun 11, 2024
17 of 23 checks passed
@Swiddis Swiddis deleted the release-notes branch June 11, 2024 18:07
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit dbf6738)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Jun 11, 2024

i did something similar a long time ago but based on copied text from github web

I almost ended up going this route because the API doesn't have a built-in way to see what the original PR is -- in GH web it's easy to find the source PR for a backport but with the API you need to infer it by pattern matching. It's still not perfect, the notes have a few backports in there, but it correctly finds the majority of the PRs (and I'm not actually sure what factors cause it to fail to find the original, it seems pretty random).

ps48 pushed a commit that referenced this pull request Jun 11, 2024
(cherry picked from commit dbf6738)

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants