Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Minor bug fixes for trace analytics v2 (#1894) #1893

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[Backport 2.x] Minor bug fixes for trace analytics v2 (#1894) #1893

merged 2 commits into from
Jun 11, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jun 10, 2024 •
edited
Loading

Description

  • Update the theming in dark mode for scale of the service map
  • Add data test-subj for cypress
  • Update truncate usage to use imported lodash
  • Add mode dependency to attributefilter useEffect
  • update test snapshots

Issues Resolved

#1820

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 added the bug Something isn't working label Jun 10, 2024
@ps48 ps48 changed the title [Backport 2.x] Minor bug fixes for trace analytics v2 [Backport 2.x] Minor bug fixes for trace analytics v2 [1894](https://github.com/opensearch-project/dashboards-observability/pull/1894) Jun 10, 2024
@ps48 ps48 changed the title [Backport 2.x] Minor bug fixes for trace analytics v2 [1894](https://github.com/opensearch-project/dashboards-observability/pull/1894) [Backport 2.x] Minor bug fixes for trace analytics v2 (#1894) Jun 10, 2024
@ps48 ps48 added the v2.15.0 label Jun 10, 2024
@ps48 ps48 merged commit 14886ce into opensearch-project:2.x Jun 11, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupal-bq rupal-bq rupal-bq approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
bug Something isn't working v2.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps48 @joshuali925 @YANG-DB @rupal-bq