Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'check for version' link in the integration details page #1879

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jun 6, 2024

Description

Adds a 'check for version' link that directs the user to the releases page for opensearch-catalog. This makes it easier to discover new content, without users needing to know ahead of time that the catalog exists. (To do: make this dynamic so external integration authors can insert their own links.)

Before:
Screenshot 2024-06-06 at 3 57 44 PM

After:
Screenshot 2024-06-06 at 3 57 08 PM

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis added enhancement New feature or request integrations Used to denote items related to the Integrations project backport 2.x labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (c3ab50f) to head (1a8fcf0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   57.85%   55.58%   -2.27%     
==========================================
  Files         372      387      +15     
  Lines       14081    14791     +710     
  Branches     3712     3930     +218     
==========================================
+ Hits         8146     8221      +75     
- Misses       5871     6495     +624     
- Partials       64       75      +11     
Flag Coverage Δ
dashboards-observability 55.58% <100.00%> (-2.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis Swiddis added the v2.15.0 label Jun 7, 2024
@Swiddis Swiddis merged commit becfa02 into opensearch-project:main Jun 7, 2024
22 of 29 checks passed
@Swiddis Swiddis deleted the feature/version-check branch June 7, 2024 23:26
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit becfa02)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Jun 10, 2024
…1884)

(cherry picked from commit becfa02)

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request integrations Used to denote items related to the Integrations project v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants