Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links #1872

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Fix dead links #1872

merged 3 commits into from
Jun 4, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jun 4, 2024

Description

Fixes dead links for the Lychee link checker. This isn't a lossless conversion:

  • Where possible, outdated links were updated.
  • Some links seemed fully defunct, these were removed outright, sometimes involving deleting docs sections that seemed outdated. e.g. many of the Zeppelin doc links and several links in the OTEL services integration.
  • Example links (to OSD instances or in one case to a local k8s cluster) were added to the lycheeignore rules.
    • There's also a playground link that causes a "too many redirects" error and also was ignored.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis merged commit e5af7eb into opensearch-project:main Jun 4, 2024
16 of 21 checks passed
@Swiddis Swiddis deleted the bugfix/links branch June 4, 2024 18:19
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
* Fix dead links

Signed-off-by: Simeon Widdis <[email protected]>

* Fix more dead links

Signed-off-by: Simeon Widdis <[email protected]>

* Add playground to ignore due to too many redirects

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit e5af7eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho pushed a commit that referenced this pull request Jun 4, 2024
* Fix dead links



* Fix more dead links



* Add playground to ignore due to too many redirects



---------


(cherry picked from commit e5af7eb)

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants