Lake formation support updates #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Swiddis
approved these changes
Jun 4, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
RyanL1997
approved these changes
Jun 4, 2024
ps48
reviewed
Jun 7, 2024
| @@ -127,7 +132,9 @@ export const NoResults = ({ tabId }: any) => { | |||
| <p>Show a list of tables within a database</p> | |||
| <EuiSpacer size="s" /> | |||
| <CreatedCodeBlock | |||
| code={`SHOW TABLE EXTENDED IN ${datasourceName}.<database> LIKE '*'`} | |||
| code={`SHOW ${ | |||
| dataSourceConnectionType === 'SECURITYLAKE' ? 'TABLES' : 'TABLE EXTENDED' | |||
There was a problem hiding this comment.
if this is just show tables query, do we want to filter them based on hive or non-hive provider?
There was a problem hiding this comment.
Security lake only supports Iceberg tables so we don't need any filtering
ps48
approved these changes
Jun 7, 2024
ps48
reviewed
Jun 7, 2024
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| export type IntegrationConnectionType = 's3' | 'index' | 'securityLake'; |
There was a problem hiding this comment.
Nit. (not blocking) Some places I see securityLake in lower case and some place in upper case. Could be better to keep it consistent.
ps48
approved these changes
Jun 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
EXTENDEDkeyword is not supportedSecurity Laketype for integrations that have at least one workflow for security lake data sources.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.