Move Cypress related dependencies to devDependencies and remove one unused dependency #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <[email protected]>
mengweieric
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
RyanL1997
approved these changes
May 15, 2024
ps48
approved these changes
May 20, 2024
ps48
reviewed
May 20, 2024
| "json5": "^2.2.3", | ||
| "mime": "^3.0.0", | ||
| "mocha": "10.1.0", | ||
| "performance-now": "^2.1.0", | ||
| "plotly.js-dist": "^2.29.1", | ||
| "postinstall": "^0.7.4", |
There was a problem hiding this comment.
Is postinstall not needed or is it part of core?
There was a problem hiding this comment.
postinstall was previously added for generating anltr artifacts after installing dependecies, but we later due to build issue start generating file manually, hence not need it anymore
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: Eric <[email protected]> (cherry picked from commit 64c71c9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
May 21, 2024
(cherry picked from commit 64c71c9) Signed-off-by: Eric <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build zip size reduced by more than 1MB
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.