[Backport 2.x] Refactor integrations setup for easier separation of different setup options #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…options (#1738) * Refactor addIntegrationRequest params to object Signed-off-by: Simeon Widdis <[email protected]> * Move SetupIntegrationFormInputs to own file Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections visually Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections logically Signed-off-by: Simeon Widdis <[email protected]> * Minor copy update for checkpoint location Signed-off-by: Simeon Widdis <[email protected]> * Update toggleworkflow method per Ryan's feedback Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit d131d99) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Swiddis
approved these changes
Apr 25, 2024
rupal-bq
approved these changes
Apr 25, 2024
Swiddis
added
integrations
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ifferent setup options (opensearch-project#1741) * Refactor addIntegrationRequest params to object * Move SetupIntegrationFormInputs to own file * Split form inputs into more sections visually * Split form inputs into more sections logically * Minor copy update for checkpoint location * Update toggleworkflow method per Ryan's feedback --------- (cherry picked from commit d131d99) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 2046537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d131d99 from #1738.