Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integrations] Reformatting integration queries #1726

Merged

Conversation

RyanL1997
Copy link
Collaborator

Description

Reformatting integration queries to address the job type issue during MV creation.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997
Copy link
Collaborator Author

@seankao-az Could you take a look?

@RyanL1997 RyanL1997 added integrations Used to denote items related to the Integrations project backport 2.x labels Apr 19, 2024
@seankao-az
Copy link
Collaborator

seankao-az commented Apr 19, 2024

https://github.com/opensearch-project/dashboards-observability/blob/main/server/adaptors/integrations/__data__/repository/aws_elb/assets/create_mv-1.0.0.sql#L60
missed one. possibly more. need individual owners to take a look

@YANG-DB YANG-DB merged commit 5bff29d into opensearch-project:main Apr 19, 2024
13 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2024
* Reformatting integration queries to address the job type issue for MV creation

Signed-off-by: Ryan Liang <[email protected]>

* Adding reformatting for elb integration

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 5bff29d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB pushed a commit that referenced this pull request Apr 19, 2024
* Reformatting integration queries to address the job type issue for MV creation



* Adding reformatting for elb integration



---------


(cherry picked from commit 5bff29d)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
) (opensearch-project#1727)

* Reformatting integration queries to address the job type issue for MV creation

* Adding reformatting for elb integration

---------

(cherry picked from commit 5bff29d)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1050dab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants