-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pattern for multiple mview suffixes #1693
Merged
Swiddis
merged 6 commits into
opensearch-project:main
from
Swiddis:feature/integ_multi_mview_pattern
Apr 15, 2024
Merged
Update pattern for multiple mview suffixes #1693
Swiddis
merged 6 commits into
opensearch-project:main
from
Swiddis:feature/integ_multi_mview_pattern
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
added
the
integrations
Used to denote items related to the Integrations project
label
Apr 15, 2024
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
April 15, 2024 21:27
YANG-DB
approved these changes
Apr 15, 2024
RyanL1997
approved these changes
Apr 15, 2024
seankao-az
approved these changes
Apr 15, 2024
rupal-bq
approved these changes
Apr 15, 2024
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
…m/Swiddis/dashboards-observability into feature/integ_multi_mview_pattern
Removing auto-backport label because timing is important for avoiding merge conflicts, will add it when the dependency backports are merged |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Update pattern for multiple mview suffixes Signed-off-by: Simeon Widdis <[email protected]> * Update field filter to new format Signed-off-by: Simeon Widdis <[email protected]> * Update all mviews for new pattern Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 72283be) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
pushed a commit
that referenced
this pull request
Apr 15, 2024
* Update pattern for multiple mview suffixes * Update field filter to new format * Update all mviews for new pattern --------- (cherry picked from commit 72283be) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Update pattern for multiple mview suffixes Signed-off-by: Simeon Widdis <[email protected]> * Update field filter to new format Signed-off-by: Simeon Widdis <[email protected]> * Update all mviews for new pattern Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 72283be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
enhancement
New feature or request
integrations
Used to denote items related to the Integrations project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update: Now I'm going with the proposed fix that breaks BWC briefly but doesn't introduce a bug (technically the prefix issue still exists but is much less likely/more work-around-able with two underscores), I think it's better to rip off the band-aid now. I've propagated this to all the merged integrations but it still needs to make its way to the in-progress ones. Including the old description below for context.
Old Description
Issues Resolved
Unblocks #1691.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.