Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(query assist) update styles for callout and combo box #1675

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Apr 8, 2024

Description

  • make callouts dismissable, auto dismiss on question or query change
  • change style of single selection in combo box
  • remove date picker if query assist is enabled

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit cad4dd47e7deffd5a8448babbe7668006bdf8889)
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 merged commit 7163e2e into opensearch-project:main Apr 9, 2024
15 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 9, 2024
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 7163e2e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 9, 2024
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 7163e2e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Apr 9, 2024
(cherry picked from commit 7163e2e)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants