Fix integration flyout successes #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
added
bug
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
YANG-DB
approved these changes
Mar 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 57.68% 57.64% -0.04%
==========================================
Files 367 367
Lines 13899 13912 +13
Branches 3644 3649 +5
==========================================
+ Hits 8017 8019 +2
- Misses 5819 5830 +11
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 91448c0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 91448c0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 91448c0) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So after getting a test instance (further context: #1643), there were More Problems. This fixes the flyout installation when an install actually succeeds. Before, the install would eternally show a loading screen while silently succeeding in the background. Now the flyout is auto-closed on success.
TODO: More tests
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.