Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Create acceleration flyout bug fixes #1621

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 263542b from #1617.

* acceleration bug fixes

Signed-off-by: Shenoy Pratik <[email protected]>

* acceleration create button update

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 263542b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 added the bug Something isn't working label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 58.01%. Comparing base (2c4d5b5) to head (7f61a0d).

Files Patch % Lines
public/framework/catalog_cache/cache_loader.tsx 37.03% 17 Missing ⚠️
...ccelerations_flyout/create/create_acceleration.tsx 6.66% 14 Missing ⚠️
...accelerations_flyout/selectors/source_selector.tsx 0.00% 12 Missing ⚠️
...s/materialized_view/group_by_tumble_expression.tsx 0.00% 1 Missing ⚠️
public/framework/datasources/direct_query_hook.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1621      +/-   ##
==========================================
- Coverage   58.05%   58.01%   -0.05%     
==========================================
  Files         365      365              
  Lines       13638    13663      +25     
  Branches     3593     3598       +5     
==========================================
+ Hits         7917     7926       +9     
- Misses       5658     5674      +16     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 58.01% <30.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 8829587 into 2.x Mar 25, 2024
23 of 36 checks passed
@github-actions github-actions bot deleted the backport/backport-1617-to-2.x branch March 25, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants