-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes and UI updates for datasources #1618
Conversation
...onents/datasources/components/manage/associated_objects/modules/associated_objects_table.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
==========================================
+ Coverage 57.71% 57.77% +0.06%
==========================================
Files 367 367
Lines 13851 13844 -7
Branches 3631 3629 -2
==========================================
+ Hits 7994 7999 +5
+ Misses 5794 5782 -12
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...onents/datasources/components/manage/associated_objects/modules/associated_objects_table.tsx
Show resolved
Hide resolved
public/components/datasources/components/manage/associated_objects/associated_objects_tab.tsx
Show resolved
Hide resolved
public/components/datasources/components/manage/associated_objects/associated_objects_tab.tsx
Show resolved
Hide resolved
...nents/datasources/components/manage/associated_objects/associated_objects_details_flyout.tsx
Show resolved
Hide resolved
ade9057
to
d038dc4
Compare
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
ec486e1
to
e7f96fd
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1618-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9428002b214d8b64846ae7134e725e4fbeb8c7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-1618-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.13
# Create a new branch
git switch --create backport/backport-1618-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9428002b214d8b64846ae7134e725e4fbeb8c7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-1618-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.13 Then, create a pull request where the |
* fixing bug with loading table columns Signed-off-by: Sean Li <[email protected]> * UI changes for datasources Signed-off-by: Sean Li <[email protected]> * adding try catch to database cache getters Signed-off-by: Sean Li <[email protected]> * addressing comments Signed-off-by: Sean Li <[email protected]> * adding refresh to create accelerations Signed-off-by: Sean Li <[email protected]> * removing osd config Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 9428002) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fixing bug with loading table columns Signed-off-by: Sean Li <[email protected]> * UI changes for datasources Signed-off-by: Sean Li <[email protected]> * adding try catch to database cache getters Signed-off-by: Sean Li <[email protected]> * addressing comments Signed-off-by: Sean Li <[email protected]> * adding refresh to create accelerations Signed-off-by: Sean Li <[email protected]> * removing osd config Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 9428002) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fixing bug with loading table columns * UI changes for datasources * adding try catch to database cache getters * addressing comments * adding refresh to create accelerations * removing osd config --------- (cherry picked from commit 9428002) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fixing bug with loading table columns * UI changes for datasources * adding try catch to database cache getters * addressing comments * adding refresh to create accelerations * removing osd config --------- (cherry picked from commit 9428002) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#1625) * fixing bug with loading table columns * UI changes for datasources * adding try catch to database cache getters * addressing comments * adding refresh to create accelerations * removing osd config --------- (cherry picked from commit 9428002) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit cb8b5f2)
Description
Accelerations
columns toAssociations
for better visibilityIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.