Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and UI updates for datasources #1618

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Mar 25, 2024

Description

  • Adds try catch for fetching tables
  • Updates Accelerations columns to Associations for better visibility
    • Skipping indices and covering indices have their associated table listed now

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 59.45946% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 57.77%. Comparing base (263542b) to head (ade9057).
Report is 1 commits behind head on main.

❗ Current head ade9057 differs from pull request most recent head e7f96fd. Consider uploading reports for the commit e7f96fd to get more accurate results

Files Patch % Lines
...nage/associated_objects/associated_objects_tab.tsx 60.00% 6 Missing ⚠️
...ated_objects/associated_objects_details_flyout.tsx 16.66% 5 Missing ⚠️
...iated_objects/modules/associated_objects_table.tsx 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   57.71%   57.77%   +0.06%     
==========================================
  Files         367      367              
  Lines       13851    13844       -7     
  Branches     3631     3629       -2     
==========================================
+ Hits         7994     7999       +5     
+ Misses       5794     5782      -12     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 57.77% <59.45%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli force-pushed the table-columns-fix branch from ade9057 to d038dc4 Compare March 25, 2024 22:47
@sejli sejli force-pushed the table-columns-fix branch from ec486e1 to e7f96fd Compare March 25, 2024 22:57
@paulstn paulstn merged commit 9428002 into opensearch-project:main Mar 25, 2024
11 of 19 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1618-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9428002b214d8b64846ae7134e725e4fbeb8c7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-1618-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1618-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.13
# Create a new branch
git switch --create backport/backport-1618-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9428002b214d8b64846ae7134e725e4fbeb8c7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-1618-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport/backport-1618-to-2.13.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
* fixing bug with loading table columns

Signed-off-by: Sean Li <[email protected]>

* UI changes for datasources

Signed-off-by: Sean Li <[email protected]>

* adding try catch to database cache getters

Signed-off-by: Sean Li <[email protected]>

* addressing comments

Signed-off-by: Sean Li <[email protected]>

* adding refresh to create accelerations

Signed-off-by: Sean Li <[email protected]>

* removing osd config

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 9428002)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
* fixing bug with loading table columns

Signed-off-by: Sean Li <[email protected]>

* UI changes for datasources

Signed-off-by: Sean Li <[email protected]>

* adding try catch to database cache getters

Signed-off-by: Sean Li <[email protected]>

* addressing comments

Signed-off-by: Sean Li <[email protected]>

* adding refresh to create accelerations

Signed-off-by: Sean Li <[email protected]>

* removing osd config

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 9428002)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Mar 25, 2024
* fixing bug with loading table columns



* UI changes for datasources



* adding try catch to database cache getters



* addressing comments



* adding refresh to create accelerations



* removing osd config



---------


(cherry picked from commit 9428002)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Mar 25, 2024
* fixing bug with loading table columns



* UI changes for datasources



* adding try catch to database cache getters



* addressing comments



* adding refresh to create accelerations



* removing osd config



---------


(cherry picked from commit 9428002)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1625)

* fixing bug with loading table columns

* UI changes for datasources

* adding try catch to database cache getters

* addressing comments

* adding refresh to create accelerations

* removing osd config

---------

(cherry picked from commit 9428002)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit cb8b5f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants