-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ag-grid dependency to 31 #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
March 21, 2024 18:52
noCharger
approved these changes
Mar 21, 2024
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
upgrade-ag-grid
branch
from
March 21, 2024 19:04
23cb758
to
cfacd0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
=======================================
Coverage 57.75% 57.75%
=======================================
Files 367 367
Lines 13825 13825
Branches 3627 3627
=======================================
Hits 7985 7985
Misses 5777 5777
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
YANG-DB
approved these changes
Mar 22, 2024
paulstn
approved these changes
Mar 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Update ag-grid dependency versions Signed-off-by: Simeon Widdis <[email protected]> * Apply ag-grid migrations Signed-off-by: Simeon Widdis <[email protected]> * Fix grid status quoting Signed-off-by: Simeon Widdis <[email protected]> * Shuffle imports and update style import paths Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 3817476) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Update ag-grid dependency versions * Apply ag-grid migrations * Fix grid status quoting * Shuffle imports and update style import paths --------- (cherry picked from commit 3817476) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintenance dependency upgrade, updating ag-grid from 27 to 31. There were a few breaking changes:
data_table.tsx
(dark styles were also merged with the standard style and don't have a dedicated import anymore). This also means that ag-grid-community is a redundant dependency since we don't seem to use any non-style functionality from it (though it's still included transiently).data_table.tsx
to update deprecated Grid API methods.any
s in this file. There's lots of weird nested type assumptions going on here and I'd need to spend more time to untangle it enough to correctly type hint the updated file.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.