Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ag-grid dependency to 31 #1604

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Mar 21, 2024

Description

Maintenance dependency upgrade, updating ag-grid from 27 to 31. There were a few breaking changes:

  • For version 29, the styles were moved to a new library and out of ag-grid-community. This required adding the new dependency and updating the imports in data_table.tsx (dark styles were also merged with the standard style and don't have a dedicated import anymore). This also means that ag-grid-community is a redundant dependency since we don't seem to use any non-style functionality from it (though it's still included transiently).
  • For version 31, there's a migration guide which mentions running a migration script, I ran the script and it applied one code update in data_table.tsx to update deprecated Grid API methods.
  • Lints: I gave it my best effort, but I'm not sure how to remove some of the anys in this file. There's lots of weird nested type assumptions going on here and I'd need to spend more time to untangle it enough to correctly type hint the updated file.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.75%. Comparing base (8f7950f) to head (3630230).

Files Patch % Lines
...ts/visualizations/charts/data_table/data_table.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files         367      367           
  Lines       13825    13825           
  Branches     3627     3627           
=======================================
  Hits         7985     7985           
  Misses       5777     5777           
  Partials       63       63           
Flag Coverage Δ
dashboards-observability 57.75% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis Swiddis merged commit 3817476 into opensearch-project:main Mar 25, 2024
14 of 21 checks passed
@Swiddis Swiddis deleted the upgrade-ag-grid branch March 25, 2024 15:56
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
* Update ag-grid dependency versions

Signed-off-by: Simeon Widdis <[email protected]>

* Apply ag-grid migrations

Signed-off-by: Simeon Widdis <[email protected]>

* Fix grid status quoting

Signed-off-by: Simeon Widdis <[email protected]>

* Shuffle imports and update style import paths

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit 3817476)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 25, 2024
* Update ag-grid dependency versions



* Apply ag-grid migrations



* Fix grid status quoting



* Shuffle imports and update style import paths



---------


(cherry picked from commit 3817476)

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants