[Backport 2.x] Enable integration install flyout for other install buttons #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Disable close button when integration is being installed Signed-off-by: Simeon Widdis <[email protected]> * Add onStartInstalling handler to disable close Signed-off-by: Simeon Widdis <[email protected]> * Re-enable close button if install fails Signed-off-by: Simeon Widdis <[email protected]> * Remove unnecessary external props from install flyout Signed-off-by: Simeon Widdis <[email protected]> * Add opening install flyout in configure integrations button Signed-off-by: Simeon Widdis <[email protected]> * Add install flyout in data connections table Signed-off-by: Simeon Widdis <[email protected]> * Update tests Signed-off-by: Simeon Widdis <[email protected]> * Don't redirect on successful integration install in flyout Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 2bc9c17) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1596 +/- ##
==========================================
- Coverage 58.10% 58.05% -0.05%
==========================================
Files 365 365
Lines 13610 13621 +11
Branches 3582 3587 +5
==========================================
Hits 7908 7908
- Misses 5638 5650 +12
+ Partials 64 63 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Mar 20, 2024
ps48
approved these changes
Mar 20, 2024
Swiddis
added
bug
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…er (opensearch-project#1596) (opensearch-project#1598) Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 1e7b4213551b6ecc4422fa9043c249521c1636bb) Co-authored-by: Ryan Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2bc9c17 from #1589.